SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5578336481
Thanks @DanielLeens for the full fresh re-review of `95cef1c0850`, and for independently confirming what I described: the change on top of `433e9b3b8bc0` is test-only and purely additive (no assertion removed or weakened), with the new stale / duplicate / increasing-sequence steps in `testRejectsStaleSequenceAndPreviousExecutionAttempt` and `testRejectsStaleEnumeratorReports` matching `CdcProgressService`'s actual tie-break semantics. Good to hear there is no new source-level blocker. To close the loop on the earlier findings, could you confirm the current status of each at `95cef1c0850` so the thread has an explicit record: - F1 – bounded `activeSplits` contract in `CdcEnumeratorProgressReport` - F2 – doc rule forbidding credentials/connection secrets in connector-native position payloads - F3 – enum fields encoded by name (not ordinal) in the engine codec - F4 – runtime collection docs vs. the registration-based enumerator report path - F5 – doc listing which connectors implement the provider today - F6 – `CdcProgressLifecycle.SNAPSHOT` Javadoc vs. the ownership rule in the doc - F7 – count field invariant validation - F8 – element immutability of `CdcSnapshotSplitProgress` behind the shallow copy If any of these are still open in your view, please say which so I can address them in a follow-up commit; if all are resolved, a short "resolved" note per item is enough for me to proceed. <!-- streview-comment:893 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
