Rangsh opened a new pull request, #12218:
URL: https://github.com/apache/seatunnel/pull/12218
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
Fixes [#12164](https://github.com/apache/seatunnel/issues/12164).
`TaskExecutionService.deployLocalTask` could leave a stale
`TaskGroupLocation` in `executionContexts` / `cancellationFutures` when a
failure happened **after** context publication but **before** / during task
submission (for example `onContextPublished`, `submitThreadShareTask`, or
`submitBlockingTask` throwing `RejectedExecutionException` during
failover/restore).
Because `deployTask` treats an existing `executionContexts` entry as an
active task and returns success without redeploying (master-failover skip
path), that leak made the location permanently un-redeployable and could hang
the job silently.
This PR:
- Publishes `executionContexts` and `cancellationFutures` together
- Rolls both map entries back when a failure occurs after publication
- Preserves the existing master-failover behavior where an already active,
healthy task still returns success without being redeployed
- Keeps the change narrow (no unrelated executor / classloader lifecycle
changes), as requested in the issue discussion
### Does this PR introduce _any_ user-facing change?
No.
This is an internal Zeta engine correctness fix. There is no config, API,
documentation, or connector behavior change for users.
### How was this patch tested?
Unit tests in `TaskExecutionServiceTest`:
1.
**`testDeployLocalTaskRollsBackAfterPostPublishFailureAndAllowsRedeploy`** (new)
- Injects a `RejectedExecutionException` in the post-publish callback
- Asserts the published execution context and cancellation future do not
leak
- Asserts a subsequent `deployTask` for the same `TaskGroupLocation`
actually redeploys and executes
2. **`testDeployTaskIdempotentWhenAlreadyRunning`** (existing)
- Confirms healthy active-task failover skip behavior is preserved
3. **`testDeployTaskHandlesFailureBeforeContextPublication`** (existing)
- Confirms the pre-publication failure cleanup path still works
Local verification:
```bash
./mvnw -pl seatunnel-engine/seatunnel-engine-server
-Dtest=TaskExecutionServiceTest -DfailIfNoTests=false -Dskip.spotless=true test
```
Result: `Tests run: 16, Failures: 0, Errors: 0, Skipped: 0`
### Check list
* [x] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [x] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [x] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [x] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
N/A for the checklist items above: no new jars, docs, incompatible changes,
or connector updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
