Rangsh commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5659635055
@SEZ9 thanks — reposting the truncated sentence cleanly, then a short scope note for your synced-head pass. ### Truncated sentence (repost) > There was previously no test that drove the failure through `flush()`/`hsync` rather than `write()` throwing at the mock boundary. Added `WALWorkHandlerSurvivabilityTest.flushFailureFromHdfsWriterShouldFailCloseSubsequentAppend`: real `HdfsWriter` with a mocked `FSDataOutputStream` where append/`write(byte[])` succeeds and only `hsync()` throws; asserts the same fail-close contract plus `verify(out, times(1)).hsync()`. No separate caveat path where flush/sync throws but the sticky fail-close flag is *not* set. ### Scope for this PR (quick) These are **in scope and already addressed** on the current head — please treat them as closed for this pass, not deferred: 1. **`RequestFuture.get()` wait behavior** — timed `get(timeout, unit)` + `TimeoutException` contract, shared batch deadline for `storeAll`/`deleteAll`, method-level Javadoc; production callers use the timed overload only. 2. **`WALWorkHandler` worker/writer handling** — `catch (Exception)`, guarded `executeResponse()`, sticky fail-close after write/flush failure, covered by `WALWorkHandlerSurvivabilityTest`. 3. **`HdfsWriterFlushSyncPathTest` / Mockito** — the mock sync-path call-count tests are **in this PR** (Mockito inherited from the parent POM; no new module dependency). What remains **intentionally out of scope** is a real `MiniDFSCluster` end-to-end harness for the HDFS branches — follow-up, as discussed earlier. This PR stays **Related to #12058** only (correctness track). Happy for you to review the synced head (`7f69d7f69`) directly. cc @DanielLeens -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
