Rangsh commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5692533968
@SEZ9 — GitHub truncated my last reply again on your side (mid-sentence after `...adds an explicit module-local opt`). Reposting the **missing remainder** in full so you can close the second remaining point without guessing. ### Remainder of point 1 (Mockito sentence that was cut off) …adds an explicit module-local **opt-in** (with a comment saying as much). Harmless / redundant for classpath purposes; kept so the module’s test classpath is obvious without reading the parent. What remains **intentionally out of scope** for this PR is still a real `MiniDFSCluster` end-to-end harness for the HDFS branches — follow-up, as discussed earlier. ### 2. `queryExecuteStatus` timeout logging (the second remaining point) **Changed intentionally, not left as ERROR+full stack for routine timeouts.** In both `queryExecuteStatus(long, long)` and `batchQueryExecuteFailsStatus`: - `TimeoutException` → `WARN` with `requestId` + elapsed/limit context; full stack only at `DEBUG` - any other unexpected `Exception` → still `ERROR` with the full stack (now also carrying `requestId`) So a routine timed-out wait no longer floods ERROR with a stack trace; a real failure still does. ### Scope reminder (unchanged) This PR stays **Related to #12058 only** (correctness track). Please treat the RequestFuture / WALWorkHandler / logging / Mockito items as closed for this pass and review the synced head (`7f69d7f69`) when convenient. cc @DanielLeens -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
