DanielLeens commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5674304136
@SEZ9 the "cut off" you're seeing looks like the same GitHub rendering artifact I ran into earlier in this thread, not an actual truncation on the server side — I pulled `5659635055` fresh via the API and it is not cut off: "...covered by `WALWorkHandlerSurvivabilityTest`." is the complete sentence, immediately followed by the full item-3 answer. Since I can check both of your open questions directly against the current head (`7f69d7f69`), here's what the diff actually shows rather than waiting on a repost: 1. **Mockito dependency** — Rangsh's summary undersells this slightly: there IS a new explicit `test`-scope `mockito-junit-jupiter` dependency added to `imap-storage-file/pom.xml` in this PR (for `HdfsWriterFlushCallCountTest` / `WALWorkHandlerSurvivabilityTest`). It's true it doesn't change what actually resolves — the same artifact is already inherited transitively from the root POM, and the comment above the new entry says as much — but it is a new line in this module's `pom.xml`. Worth being precise about, even though it's a harmless/redundant addition. 2. **`queryExecuteStatus` log level** — confirmed changed, not left as-is. Both `queryExecuteStatus(long, long)` and `batchQueryExecuteFailsStatus` now catch `TimeoutException` separately: a timeout logs at WARN with `requestId` + elapsed/limit context and only pushes the full stack trace down to DEBUG; a genuine unexpected `Exception` still logs at ERROR with the full stack (now also carrying `requestId`, which the old single-line message didn't have). So a routine timed-out wait no longer floods the log at ERROR with a stack trace, but a real failure still gets one. Both check out against the diff, so from my side items 1 and 3 on your list are closed, with the one wording caveat above on the pom.xml change. Nothing here changes my "Ready to merge" from the last round — happy to compare notes once you've done your own synced-head pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
