SEZ9 commented on PR #12299: URL: https://github.com/apache/seatunnel/pull/12299#issuecomment-5707857689
Following up on the CI status noted above: the two red legs are tracked upstream as #12344 (`OpengaussCDCIT.testAddFieldWithRestore`) and #12345 (`NebulaGraphIT` startup flake), and I agree neither is related to this diff. The head is still `9531cecd4`, so there is nothing new on the code side for me to re-review yet — the remaining items from my previous review are unchanged. To move this forward, here is what I still need on the next push: 1. **Single charset for the log file (F1)** — please make the within-limit and over-limit paths in `FileUtils` decode with the same charset (UTF-8 is fine), rather than platform-default in one branch and UTF-8 in the other. 2. **Compatibility record + v1 docs (F2 / F4 / F6)** — the default 64 MB tail now applies to both the v2 and v1 log-content endpoints. Please add an entry to `incompatible-changes.md` and update `rest-api-v1.md` (en/zh) so the option is not documented only on the v2 page. 3. **Truncation marker (F3 / F4)** — a truncated response should carry some indicator (a header or a leading line) so the Web UI iframe and API consumers can tell the head of the file was dropped. If you have a preferred shape for this, let me know and we can settle it here. 4. **Extra copies in `tailFromLineStart` (F5)** — the retained window is copied again after the initial read, so the tail is materialised several times per request. Please trim this to a single retained buffer, or explain why the additional copies are needed. 5. **Docs wording (F7)** — replace the hard-coded "last 64 MB" with a reference to the configured value, and remove the stray double backtick in the zh page right above the new note. 6. **Duplicated MB→bytes / `<=0` sentinel (F8)** — factor the conversion shared by `LogBaseServlet` and `LogService` into one helper. Once those land on a new commit and `Build` is green (after the fixes for #12344/#12345 or a rebase past them), I'll do a final pass. If any of the above is already addressed somewhere I've missed, just point me to it. <!-- streview-comment:1116 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
