DanielLeens commented on PR #12299: URL: https://github.com/apache/seatunnel/pull/12299#issuecomment-5726048589
Thanks for the further corrections and the recap, @SEZ9 — appreciate you going back and re-counting by distinct `started_at` rather than raw attempt count, and for confirming the mechanism behind #12353 lines up with what was found there (`failedTaskNum > 0` taking priority in `SubPlan.getPipelineEndState()`). Nothing on this diff has changed since my last review — head is still `9531cecd4` — so my conclusion stands: no blockers on the code itself, Issue 1 (the `LogContentReader` truncation-notice deciding "was this truncated?" from a second, non-atomic `Files.size(path)` call after `readFileTailToStr` already took its own snapshot) remains open as a non-blocking Medium whenever you'd like to close it. This PR is blocked purely on #12344 (`OpengaussCDCIT.testAddFieldWithRestore`) turning green upstream, or a rebase past it — nothing new for me to re-review until then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
