SEZ9 commented on PR #12299: URL: https://github.com/apache/seatunnel/pull/12299#issuecomment-5724203237
Quick status from my side: the head is still `9531cecd4`, so there is no new diff to re-review and my earlier recommendation stands unchanged — no blockers on the code itself. The only open item remains Issue 1 as a non-blocking Medium: the `LogContentReader` truncation notice decides "was this truncated?" from a second, non-atomic `Files.size(path)` call after `readFileTailToStr` has already taken its own snapshot. If you'd like to close it in this PR, returning the truncated flag together with the content from the same snapshot would resolve it; otherwise it can follow up separately. The control run `35166337277` is helpful context for the unrelated failures and doesn't change anything above. Once `Build` is green (after the tracked dev-side fixes land or this branch rebases past them), this is mergeable from my side. <!-- streview-comment:1129 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
