DanielLeens commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5713023749
Thanks for the correction and the transparency, @201811510411lw — noted that the collaboration attempt via zhangshenghang/seatunnel#19 did not land, and that the candidate is now a standalone PR: apache/seatunnel#12366. For the record on this PR's (#12301) own status: the head is still `48264cda6a`, unchanged since my last review here (2026-09-15) — no functional code has landed on this branch since 2026-09-13. So the two blocking issues from my earlier review remain open on this specific PR: (1) the `SupportSinkDataPartition` check in `SinkExecuteProcessor` still evaluates on the `MultiTableSink` wrapper rather than the real per-table sink, so the partitioner is never constructed on a real Paimon-on-Flink job, and (2) the partitioner would still crash on `BroadcastSchemaSinkOperator`'s zero-field schema-control rows. Neither is fixed on this branch. @zhangshenghang — worth flagging directly: #12366 now targets the same #12243 fixed-bucket data-loss bug via a very similar mechanism (routing through the real `MultiTableSink` path, schema-control rows routed by `schema_subtask_id`), and has already gone through a full review round there. You and @201811510411lw may want to coordinate on which PR should carry this fix forward, to avoid two implementations of the same root-cause fix landing independently. I will hold off on a fresh full review of #12301 unless/until new commits land on this branch specifically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
