SEZ9 commented on PR #11307:
URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-5724693205
@goutamadwant thanks for confirming — the FilterRowKind failures ran on
Flink 1.15.3/1.18.0 rather than Spark 3.5.8, so run `34918482860` doesn't count
against this PR, and good to hear a real Spark 3.5.8 batch job went through the
current launcher.
Status on head `d3d34f292`, to keep this in one place:
- **F1 / F5 (Windows launcher):** the delayed-expansion and
swallowed-exit-code bugs were fixed by `ee21221df89c`; I've already re-checked
the current `.cmd`. What remains is narrower — the resolved args are still
assembled into one string before being passed to `spark-submit.cmd`. Since
native Windows execution is still unverified, a real Windows run (ideally with
a config path containing spaces and a shell metacharacter) showing the args
arrive intact and a failing job returns non-zero would close this out.
- **F2 (`eval` in the `.sh` launcher):** closed via the NUL-delimited args
file — nothing further needed.
- **F6 (unquoted `args=$@` / `${args}` / `${CLASS_PATH}` in the `.sh`
launcher):** still open as far as I can tell; please point me at the change if
it has already been handled.
- **F4 (both `log4j-slf4j-impl` and `log4j-slf4j2-impl` in the starter
logging include list):** still open; a fix or a note on why both are needed
would resolve it.
- **F7 (streaming on 3.5.8):** still unverified, as you noted — a
micro-batch streaming job actually run on Spark 3.5.8, or an IT covering that
path on the Spark 3.5 container, would close it.
- **F3 / F8:** resolved via the Spark engine docs — no action needed.
Happy to do a final pass once the open items above are in.
<!-- streview-comment:1141 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
