SEZ9 commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-5754554100
Thanks for the recheck, @goutamadwant. Mapping your notes back to the open points: **Shell launcher (F2 / F6)** — "preserves literal arguments without evaluation" sounds like the eval-based execution is gone. Could you confirm how the final command line is executed now, and that the arguments and classpath variables are quoted so word-splitting/globbing no longer applies? A short paste of the relevant lines here is enough. **Windows launcher (F1 / F5)** — "exit-code capture remains outside the expansion-sensitive block" addresses F5, but F1 is the bigger one: the `!errorlevel!` / `!CMD!` comparisons and the final `call` need to run where delayed expansion is actually enabled, otherwise they operate on literal text. Please confirm where `setlocal disabledelayedexpansion` sits relative to those expansions, and what the script does when the starter java process exits non-zero with empty stdout. **Logging (F4)** — not covered in your update. Are both `log4j-slf4j-impl` and `log4j-slf4j2-impl` still in the starter logging include list? If so, one of them should be dropped or excluded for the 3.5 starter, since the launchers put `starter/logging/*` on the classpath. **Translation reuse (F3)** — fine as an explicit, documented limitation. Please confirm the note is user-facing in the docs, not only in the PR description. **Streaming coverage / docs (F7 / F8)** — understood that micro-batch streaming coverage is not being claimed. Then the quick-start should not steer Spark 3.5 users to the streaming template without a caveat, or we add a minimal streaming test on 3.5.8. Likewise, if 3.4 launcher behavior is retained, the engine docs should say what Spark 3.4.x users run rather than narrowing `seatunnel-spark-3-starter.jar` to "Spark 3.3.x" only. On the failures: noted that FilterRowKind is on Flink 1.18 and OpenGauss/checkpoint have separate fix tracks — I'll treat those as out of scope here. Once the JDBC part-6 retry finishes and the items above are confirmed (F1/F4 especially), I'll do a final pass. <!-- streview-comment:1201 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
