SEZ9 commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-5944531641
Thanks for the follow-up. My approval at `70f4b602a6` still stands, and the Windows launcher issue raised earlier was already fixed there. The only new commit since then is `b1718c2301`, which flips the Spark 3.5 container's `testInPR` flag to `false` and drops the now-dead `SPARK_3_5` branch in `ContainerUtil.java`. That is a reasonable CI-scoping change, and it does not touch the launchers, poms or docs. One consequence worth confirming: because the Spark 3.5 starter reuses the Spark 3.3 translation layer, any Catalyst binary mismatch against 3.5.8 would only surface at job runtime, and with the container out of PR runs there is no longer a PR-time signal for it. Could you confirm the scheduled workflow still picks up the Spark 3.5 container and that it passes on the current head? Two smaller points from the earlier review that would be nice to close out if they are not already covered: a micro-batch streaming test on 3.5.8 (or an explicit note in the PR description that it is deferred), and a line in the docs on which starter Spark 3.4.x users should pick. Happy to re-review once that is confirmed. <!-- streview-comment:1457 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
