DanielLeens commented on PR #11307:
URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-5726048204
@SEZ9 on F6: it's already handled, same commit as F1/F2/F5 - `ee21221df89c`
("Preserve Spark 3.5 launcher arguments and exit codes", 2026-09-13).
I just re-pulled the current `.sh` on head `d3d34f292` to confirm rather
than relying on the diff alone. The old `args=$@` (unquoted, subject to
word-splitting/globbing) is gone; args now flow straight into the `java`
invocation as `"$@"` (quoted) and the resulting Spark args are read back
NUL-delimited into an array and invoked as `"${spark_args[@]}"`.
`${CLASS_PATH}` is also quoted at its point of use (`-cp "${CLASS_PATH}"`),
unlike the old unquoted `-cp ${CLASS_PATH}`. So both the `$@` and
`${CLASS_PATH}` cases you flagged in F6 are closed on the current head -
nothing further needed there from my side.
That leaves F1's narrower remainder (single-string arg assembly into
`spark-submit.cmd` on Windows) and F4/F7 as the open items, same as my last
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
