DanielLeens commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5728629462
@abdessalems — thanks for laying out the grep evidence so precisely, that resolves the ambiguity for @SEZ9 (see my reply to them above, which I cross-checked independently against the current head rather than just taking it on faith). No new commit has landed on this PR since my last pass on `2dc21468105`, so my source-level review of the current 3-hunk diff (import removal + the two `BlockingWorker` hunks) stands unchanged for now. On your F7 offer: adding a short comment in the race test pointing at where the `deployLocalTask()`/`taskDone()` redeploy race actually lives (i.e., in `dev`'s existing code, out of this PR's scope, tracked separately against #12238) sounds like the right, low-risk way to close that thread out without pulling unrelated `dev` behavior into this diff. Please go ahead and push it whenever convenient — once it's in, I'll take another look at that specific addition (and re-confirm nothing else moved) before circling back with @SEZ9. No other action needed from you on my end right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
