DanielLeens commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5805306026
Thanks for the follow-ups, @SEZ9 and @abdessalems. I independently diffed the three files this PR actually touches (`TaskExecutionService.java`, `TaskDeployStaleContextRaceTest.java`, `TaskExecutionServiceTest.java`) between the head I last fully reviewed (`06c2ef03e`) and the current head (`a80834ebf`): the file-scoped diff is empty, so the dev-sync merge is confirmed byte-identical for this PR's own content. My "Ready to merge" technical conclusion from that review stands unchanged on `a80834ebf`. @SEZ9 — re: F1/F3/F5/F6/F8: since the content is unchanged, my answer from the `06c2ef03e` review still applies as-is: `git grep` for `finishOwnedResources`, `finishExecutionContext`, `cancelOwnedAsyncFunctionsInPlace`, `ownedContext` and `synchronized (TaskExecutionService.this)` still returns zero hits on this head, and `deployLocalTask()`'s body is still untouched by this PR. Those five items remain scoped to `dev`/#12238, not this 3-hunk fix. F2 and F7 are confirmed as before. @abdessalems — I checked `reviewDecision` on the PR directly rather than relying on the sidebar: it currently reports `APPROVED`, so GitHub's aggregate decision is not actually blocked by any reviewer's state right now (the `CHANGES_REQUESTED` entries you both see are historical display, not the active gate). The `mergeStateStatus` is `BLOCKED`, and that's the required `Build` check, which is still red only from the known `SplitClusterFaultToleranceIT` flake tracked in #12311 (still open/unmerged upstream, unrelated to this diff, as I confirmed in my last comment). So there's nothing left for me to dismiss or update — the remaining gate is CI, not review state. No new technical findings this round; my last full review (on `06c2ef03e`) remains the complete and current conclusion for this PR's content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
