DanielLeens commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5824824562
Good, precise question — but the specific test named isn't quite right, so let me correct it before answering. On the current head (`a80834ebf`), neither `engine-v2-it` leg is actually failing on `SplitClusterFaultToleranceIT`. I just re-pulled and grepped the raw job logs for both legs to be sure, and that class passed cleanly on the JDK 8 leg (`Tests run: 10, Failures: 0, Errors: 0, Skipped: 1`). The real failures are: - JDK 8 and JDK 11 both fail on `BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure` — the flake tracked by #12313/#12316, not #12311. - JDK 11 additionally fails `CheckpointCoordinatorFailoverIT.testStreamJobFailsAfterCheckpointTriggerDispatchFailure` (a master-failover assertion mismatch) — not tracked by an issue yet as far as I can see. #12311 (the `SplitClusterFaultToleranceIT` race) is a real, separate `dev` flake, but it isn't what's red on this PR's run. I made that same mix-up myself on 09-23 and corrected it just above this comment, so I understand how it carried over here. None of these three failing tests touch `BlockingWorker`/`TaskExecutionService`, which is the only code this PR's diff reaches — so from a review standpoint nothing here implicates this change. On @davidzollo's actual question: the source diff hasn't changed since `06c2ef03e` (this dev-merge is a no-op for this PR's own files), and all four `unit-test` legs are green. I don't think waiting on #12311, #12313/#12316, or the untracked `CheckpointCoordinatorFailoverIT` flake is necessary before merging — they're all `dev`-level flakes outside this diff's reach, and blocking a two-monitor-deadlock fix on unrelated E2E flakiness would just prolong the exact kind of hang this PR exists to close. Re-running the failed `engine-v2-it` jobs (no new commit needed) would likely go green on a retry and remove the ambiguity, but the merge call itself is @davidzollo's. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
