SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5863703629
@goutamadwant thanks for syncing with dev. I haven't re-verified the PR-owned files at the current head `5165e0878b95` myself, so rather than restate the earlier points as open, could you give a short per-item status for F1–F8 (fixed / not applicable / defer to follow-up)? A few specifics: - **F1 / F8** – the thread indicates the `CdcEnumeratorProgressReport` constructor truncates via `subList` before wrapping in an unmodifiable list, and that `CdcSnapshotSplitProgress` and the types it references are deeply immutable. If that's accurate for the current head, I'm happy to treat both as closed — a quick confirmation is enough. - **F3** – please confirm (or point to a test) that the engine codec encodes `CdcProgressAccuracy` and the other public enums by name rather than ordinal. - **F2, F4, F5, F6** – have the `docs/en/developer/cdc-progress.md` and `CdcProgressLifecycle.SNAPSHOT` Javadoc updates landed, or would you prefer to handle them in a follow-up? - **F7** – a minimal invariant check on the count fields (or a Javadoc note explaining why not) would close this. Once those are confirmed I don't see anything else blocking from my side. Thanks! <!-- streview-comment:1382 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
