SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5806590119
Thanks for the detailed rundown on `0b38a3d9b7c2` (effective diff `dfabd777e98..0b38a3d9b7c2`, with `732cdd06fca` being the dev-sync merge). Before I sign off I'd like to tie each of F1–F8 to something concrete in the diff rather than to the status summary, so the same standard applies to all of them. Could you add direct pointers for: 1. **F1 (bounded `activeSplits`)** – where the bound is actually enforced in `CdcEnumeratorProgressReport` (the check and the limit value). If it is documented-only, please say so and we can decide whether that is acceptable. 2. **F2 (no secrets in native positions)** – the doc wording that forbids credentials/connection secrets in connector-native position payloads. 3. **F3 (enum encoding by name)** – the byte-fixture round-trip test that decodes `CdcProgressAccuracy` and the other report enums from literal string fixtures. 4. **F4 (registration-model wording)** and **F5 (named connector list incl. the TiDB/Vitess "not wired" callout)** – the doc sections as they stand at the current head. 5. **F6 (`SNAPSHOT` Javadoc narrowing)** – the current Javadoc text. 6. **F7 (count invariants)** – does the class now reject negative / mutually inconsistent counts, or does `CdcProgressModelTest` only exercise the current permissive behavior? If the latter, I'm fine deferring it as LOW, but let's state that explicitly. 7. **F8 (deep immutability claim)** – `final` fields plus a Javadoc sentence don't by themselves make `CdcSnapshotSplitProgress` elements immutable. Please confirm `CdcSnapshotSplitProgress` has no setters / mutable collections, or soften the Javadoc to "shallow copy of an unmodifiable list". Once those pointers are on the PR I'm happy to approve; nothing outside this list from me. <!-- streview-comment:1276 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
