SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5882640017
Thanks for keeping the branch in sync with `dev`. From what I can see, `ec6a7f9affc...e72541e9fe18` is a pure `dev` merge that doesn't touch this PR's own files, so it doesn't change the earlier review points. Before merging I'd like to close those out explicitly on this head. Could you confirm (or point me to where it was handled) for each: - **F1 (E2E readiness wait)** — is the `received new worker register` wait strategy now applied when the container is configured rather than in `executeExtraCommands`, so it actually gates server readiness in `FakeSourceToConsoleWithEventReportIT`? - **F2 / F3 (`close()` robustness)** — when the scheduler fails to terminate, does `close()` still flush the local buffer concurrently with the interrupted task, and can failures other than `HazelcastInstanceNotActiveException`/`IOException` still escape `close()`? - **F4 / F6 (Kotlin stdlib split)** — are we still resolving `kotlin-stdlib` 1.8.21 alongside `kotlin-stdlib-common` 1.9.10 in the dist, and do `known-dependencies.txt` and the release LICENSE match what actually resolves? Pinning to a single version would be preferable. - **F5 (`testRetryAfterHttpFailure`)** — does `takeRequest()` now have a timeout, are the request `Buffer`s closed, and does the test no longer rely on the scheduler firing immediately despite the 1-day interval? - **F7 (redirects)** — is redirect following disabled on the `OkHttpClient` so configured headers/tokens can't be forwarded to another host? - **F8 (Content-Type)** — have you verified the `; charset=utf-8` suffix added by `RequestBody.create(String, MediaType)` doesn't change the header existing collectors see, or switched to a form that preserves the configured media type exactly? A short per-item status (fixed in which commit, or intentionally left as-is with rationale) is all I need; happy to do a final pass once that's up. <!-- streview-comment:1392 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
