SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5852114232
Thanks for the detailed re-check against `ec6a7f9affc`. **F1, F2/F3, F4/F6.** Your description of the call order in `executeExtraCommands`, the `close()` structure, and the `kotlin-bom` import is helpful and consistent with what would address these points. Since no new commit has landed since `ec6a7f9affc`, I'll re-verify these directly against the changed files at that head rather than closing them on the description alone, and I'll update the findings once that's done. Your comment also appears to be cut off after "no `1.8`" — no need to repost, I'll check the inventory files myself. **Still open — not covered in this update:** - **F5** (retry test): is `takeRequest()` now called with a timeout, are the request buffers closed, and how does the test trigger the retry rather than relying on the 1-day scheduler interval? - **F7** (redirects): has redirect following been disabled on the `OkHttpClient`, or is there a reason forwarding the configured report headers on redirect is acceptable here? - **F8** (`Content-Type`): is the emitted header unchanged for existing collectors, or is the `; charset=utf-8` suffix intentional? A short pointer for each of F5/F7/F8 (or a note that they'll land in a follow-up) is all that's needed to wrap this up. <!-- streview-comment:1355 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
