SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5788563231
Thanks for the follow-up commits. As I read the thread, `8f4dce57d45`, `af9b89d9e` and `ec6a7f9affc` are described as license/merge-only, with no code or test changes since `73f66f922`. If that is right, the code-level items from my previous review are still open. A one-line pointer per item is enough if it was already handled; for anything still open, a small follow-up commit would be great. - **PR11814-F1 (E2E wait strategy)** – Is the `received new worker register` wait still configured in `executeExtraCommands`? If it was moved so that it actually gates server readiness, please point me to where. - **PR11814-F2 / PR11814-F3 (`close()` robustness)** – How does `close()` behave when the scheduler does not terminate in time? Does it still flush the local buffer while the interrupted task may be running, and does it catch anything beyond `HazelcastInstanceNotActiveException`/`IOException`? A short description of the current logic is fine. - **PR11814-F4 / PR11814-F6 (Kotlin stdlib graph)** – Could you point me to the diff where the Kotlin stdlib version is pinned in `seatunnel-engine-server/pom.xml`? Please also confirm that `tools/dependencies/known-dependencies.txt` and `seatunnel-dist/release-docs/LICENSE` now list a single Kotlin version matching the resolved dist (no remaining 1.8.21 entries). - **PR11814-F5 (testRetryAfterHttpFailure)** – Does the test now use a bounded timeout on `takeRequest()`, close the request `Buffer`s, and drive the scheduler explicitly rather than relying on it firing immediately with a 1-day interval? - **PR11814-F7 (redirects)** – Is redirect following disabled on the `OkHttpClient`, or is there a reason to keep the default given the configured report headers? - **PR11814-F8 (Content-Type charset)** – Is the emitted `Content-Type` byte-identical to the previous behaviour, or is the `; charset=utf-8` suffix one of the intentional changes documented in `incompatible-changes.md`? Nothing new from my side beyond these. <!-- streview-comment:1258 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
