SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-5923292159
Thanks @sudeephazra for the detailed pointers. **Trimmed values (PR12293-F1):** Routing `ADLSHadoopConf` through the same `ADLSConfigValidator.required()` helper for account, container, endpoint suffix, shared key and the OAuth values is the shape of fix I was hoping for; I'll verify it against the diff. One small thing: the two test references you gave point at different root paths — could you confirm which file `configuresOAuthClientCredentials()` lives in? **HNS prerequisite (PR12293-F2):** Your comment appears to be cut off right after the English sink documentation link. Could you paste the rest? In particular I'd like to confirm (a) the Chinese sink doc carries the same prerequisite, and (b) the wording ties HNS to the atomic `tmp_path` -> `path` rename, so the exactly-once / transactional-commit claim is clearly conditional on a hierarchical-namespace-enabled account. Still open from the earlier review, unless they were handled in the same push: - F3 – document the validation rules (account/container naming, auth mutual exclusion, blocked `hadoop_adls_properties` keys) and fix the template placeholders so they pass them. - F4 – validate `authority_host` / `tenant_id` before building the token endpoint (https-only, expected host shape). - F5 – sync the en/zh sink option tables with what the factories expose. - F6 – mention the `ConfigShadeUtils` `account_key` mask-list addition in the docs and the PR description. - F7 – fix the English source doc defaults for `discovery_mode` (ONCE) and `start_mode` (EARLIEST). - F8 – tighten the `hadoop_adls_properties` denylist to also block class-loading / token-provider keys, or soften the documented contract. A short pointer per item, like the ones above, is all I need. <!-- streview-comment:1433 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
