sudeephazra commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-5926714875
Thanks for following up. Here are the pointers: - F1: configuresOAuthClientCredentials() lives in [seatunnel-connectors-v2/connector-file/connector-file-adls/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConfTest.java, line 72](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/seatunnel-connectors-v2/connector-file/connector-file-adls/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConfTest.java#L72). The earlier root-path mismatch was incorrect. - F2: The complete explanation is that transactional commit and exactly-once semantics require an HNS-enabled account because commit relies on the atomic rename from staging under tmp_path into path. Both paths must use the same container. Both the [English prerequisite](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/en/connectors/sink/ADLSFile.md#L39) and [Chinese prerequisite](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/zh/connectors/sink/ADLSFile.md#L31) state the HNS requirement and explain the partial-output risk without it. - F3: Naming rules, auth mutual exclusion, and blocked Hadoop properties are documented in the [English configuration rules](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/en/connectors/sink/ADLSFile.md#L100) and [Chinese configuration rules](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/zh/connectors/sink/ADLSFile.md#L85), also mirrored in the source docs. The [template](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/config/v2.batch.adls.config.template#L39) now uses naming-valid placeholders; the account key still requires an environment value. - F4: [ADLSRuntimeCompatibility](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSRuntimeCompatibility.java#L124) validates both values before constructing the token endpoint. The authority requires HTTPS and a parseable host, rejects userinfo/path/query/fragment, and accepts a trailing /. The tenant must be a GUID or DNS name. - F5: The [English sink table](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/en/connectors/sink/ADLSFile.md#L52) and [Chinese sink table](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/zh/connectors/sink/ADLSFile.md#L37) now reflect the factory’s exposed options and defaults. - F6: Both languages document that account_key masking is a global core-starter default: [English](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/en/connectors/sink/ADLSFile.md#L117), [Chinese](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/zh/connectors/sink/ADLSFile.md#L102). - F7: The [English source table](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/docs/en/connectors/source/ADLSFile.md#L73) now shows discovery_mode = ONCE and start_mode = EARLIEST. - F8: The [denylist](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSConfigValidator.java#L97) now additionally blocks SAS/delegation-token providers, delegation-token enablement, identity transformers, and shell-key-provider settings. Coverage is in [rejectsCredentialAndClassLoadingAdvancedProperties()](https://github.com/sudeephazra/seatunnel-adls-connector-v2/blob/781ba2ec/seatunnel-connectors-v2/connector-file/connector-file-adls/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSConfigValidatorTest.java#L65); the docs enumerate the blocked prefixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
