li3zhi4 commented on PR #11746: URL: https://github.com/apache/seatunnel/pull/11746#issuecomment-6035492606
Straight mapping \u2014 the two items on `02a265f51` are exactly points **4** and **5** of your five-item list:\n\n- **docs change (Upgrading/\u5347\u7ea7\u63d0\u793a in `docs/en`/`docs/zh` `Jdbc.md`) = your point 4 \"Upgrade note / opt-out\".** It adds the upgrade section you asked for and names `partition_column` as the documented way back to the single-column split.\n- **`FixedChunkSplitter` throwing `JdbcConnectorException` on a multi-column key + the explicit comment on `findSplitKey`'s dynamic-only gate = your point 5 \"Removed single-split-key guard\".** Both of the alternatives you offered are covered: the composite branch in `findSplitKey` was already gated on `config.isUseDynamicSplitter()` (`ChunkSplitter.java:431-433`, now documented at `:428-430`), and the fixed path now fails loudly instead of silently splitting on field 0 (`FixedChunkSplitter.java:65-76`). New tests: `testFixedSplitterFindSplitKeyNeverReturnsCompositeKey` and `testFixedSplitterRejectsCompositeSplitK ey`.\n\nPoints 1-3 of your list were pointer-only (already implemented on the earlier heads): 1 = SQLite NULL PK capture/guards, 2 = separator Javadoc, 3 = `compareCompositeElement` \u2014 locations as in my previous comment.\n\nCI on `02a265f51`: same picture as `27e0c53013` \u2014 `Dead links` red on the upstream `README.md` badge, plus `updated-modules-part-1/2`, `edge-agent-it (8)`, `paimon (11)`, all from the `dev`-inherited flake families; failed-job rerun is in flight and I'll post the outcome.\n -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
