ricky2129 commented on PR #12710:
URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6096509357
Thanks @SEZ9.
1. The description covers the motivation (SIGTERM is dropped by `/bin/sh` as
PID 1, so the JVM is always SIGKILLed after the grace period) and the change.
There's no separate issue; happy to open one if you prefer.
2. No unit/e2e test was added: the change is the startup script and the Helm
template, and the behaviour is signal delivery to PID 1. It is covered by the
before/after `docker stop` A/B in the description (exit 137 after 30s vs exit
143 in under 1s with the shutdown hook running).
3. CI didn't trigger on the first push ("workflow run detection failed"); I
pushed an empty commit to re-trigger it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
