SEZ9 commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6136749606
Thanks @ricky2129 for the detailed follow-up. **Shutdown policy:** keeping the `SeaTunnelServer.shutdown` / graceful-policy change out of this PR works for me; it changes how running jobs stop and deserves its own discussion and testing. Having the description say plainly that this gives a fast, clean exit from the cluster on SIGTERM, not a graceful stop of running jobs, addresses my concern, as does the note that `GRACEFUL` only lets Hazelcast migrate partition data before the member leaves and that tasks still recover from their last checkpoint. **Docs:** the "Health Check and Shutdown" restructure on the hybrid and separated K8s pages (en/zh) sounds like the right direction: leading with the exec-form `command` and `terminationGracePeriodSeconds`, and moving `preStop` + `stop-seatunnel-cluster.sh` to an optional tip for setups that must keep `/bin/sh -c`. I'll read through the updated pages and the "Rolling Updates" changes on the current head and follow up if anything doesn't match the described behaviour. <!-- streview-comment:1703 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
