ricky2129 commented on PR #12710:
URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6163401442
Thanks @SEZ9. All three are in on the current head `45a4730f`:
1. **Shutdown policy (F1):** kept out of this PR as agreed on 10-13. The
description's "Scope" paragraph and the user-facing section state that SIGTERM
gives a fast, clean exit from the cluster, not a graceful stop of running jobs,
and that tasks recover from their last checkpoint.
2. **`terminationGracePeriodSeconds` (F2):**
`deployment-seatunnel-master.yaml:43-44` and
`deployment-seatunnel-worker.yaml:43-44`, driven by
`master.terminationGracePeriodSeconds` / `worker.terminationGracePeriodSeconds`
in `values.yaml` (default 30, the Kubernetes default). The values comment notes
that with `GRACEFUL`, `hazelcast.graceful.shutdown.max.wait` must stay below it.
3. **Docs (F3):** "Health Check and Shutdown" in
`docs/{en,zh}/getting-started/kubernetes/hybrid-cluster-mode.md` and
`separated-cluster-mode.md` lead with the exec-form `command` +
`terminationGracePeriodSeconds`, describe the SIGTERM → shutdown-hook
behaviour, and move `preStop` + `stop-seatunnel-cluster.sh` into an optional
tip for setups that must keep `/bin/sh -c`. `operations.md` "Rolling Updates"
links there.
Since then the branch has only been rebased on `dev`; none of the PR's own
files changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
