davidzollo commented on PR #11613: URL: https://github.com/apache/seatunnel/pull/11613#issuecomment-6096592904
@SEZ9 thanks for re-listing. Items 1 to 7 were addressed in `5faae3e27` (pushed 2026-10-09, see my summary comment above); `a125187` just added the remaining pieces you asked for today. Per item: 1. Flat `/update-tags` example: plain `tag1`/`tag2` keys, a "no key is reserved" statement (`5faae3e27`), and now an explicit "tag values must be strings; nested objects are not a supported value type" sentence in en and zh (`a125187`). 2. REST coverage: `RestApiIT#testHttpServiceStatusReportsEffectivePortsWithoutSecrets` and `RestApiIT#testUpdateLocalMemberTagsOnlyMutatesTheServingMember` (`5faae3e27`); the latter also exercises the legacy flat payload path on both the Jetty and Hazelcast ports. The pre-existing `testUpdateTagsSuccess` / `testClearTags` keep covering flat `/update-tags`. 3. Auth chain: `BasicAuthenticationIT#testOperationEndpointsRequireCredentials` and `#testOperationEndpointsWithCorrectCredentials` (`a125187`) assert 401 without credentials for `/http-service/status`, `/update-local-member-tags` and `/update-tags`, and that authenticated requests reach the servlets (status reports `basicAuthEnabled=true`; the tag endpoint returns its own UUID-mismatch 400 rather than a filter 401). Docs state the shared chain in both endpoint sections. 4. Local-only UUID validation: documented as a limitation in the new `/update-local-member-tags` section and on the Web UI Workers page, en and zh (`5faae3e27`). 5. Dedicated `/update-local-member-tags` section with request, success response and an error table (`5faae3e27`). 6. Restore Latest State: implemented server-side in `JobInfoService.validateCheckpointRestoreRequest`, which refuses a restore while the source job is in any non-end state (400 with a clear message) and leaves the existing `No checkpoint found` error for cleaned-up state; the submit panel shows the engine message. Tests: `JobInfoServiceRestoreGuardTest`, a REST case for a non-numeric source ID, and a `jobs.spec.ts` case. Documented in the REST lifecycle note and the Web UI Checkpoints bullet (`5faae3e27`). 7. `/http-service/status`: per-field table and `8080`/`8443` example ports (`5faae3e27`). 8. Screenshots: still open; not refreshed in this PR. On CI: the fork is affected by GitHub's usage-based fork workflow disable (banner on the fork's Actions page: "Workflows are not currently being run on this fork due to the scale of GitHub Actions usage"). The REST API reports Actions enabled and the workflow active, so the earlier Settings-based advice does not clear it; only the maintainer's enable button on the Actions page does. That click is pending on the fork owner; once it is done I will push an empty commit so a run exists for the head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
