SEZ9 commented on PR #11613: URL: https://github.com/apache/seatunnel/pull/11613#issuecomment-6096251250
Thanks for the work on this PR. On CI: as davidzollo mentioned above, no fork `Build` workflow run has been created for this branch since `5faae3e27` (and again after the empty commit `9272fba`), so the `Build` check is stuck at `action_required` (https://github.com/apache/seatunnel/runs/113736126135). Please enable Actions on your fork (Settings -> Actions -> General) and push an empty commit, or ping here and one of us will re-trigger it. Until a fork run exists for the current head I can't verify the build or tests, so the points below are based on reading the diff only. From the earlier review, these are still open from my side: 1. **Docs – legacy `/update-tags` example** (`docs/en/engines/zeta/rest-api-v2.md`): the example key name suggests nested object values are accepted, while the contract is a flat `Map<String,String>`. Please rename the key and add a sentence stating that values must be strings. 2. **Tests – REST coverage**: the two new endpoints and the legacy `/update-tags` behaviour only have isolated unit tests. Please add `RestApiIT`/E2E cases covering `/update-local-member-tags`, `/http-service/status`, and the old flat `/update-tags` payload. 3. **Security – auth chain** (`JettyService.java`): please confirm (ideally with an IT case) that `/update-local-member-tags` and `/http-service/status` are behind the same basic-auth/mTLS handler chain as the existing servlets, since one mutates state and the other discloses status. 4. **Functional – local-only UUID validation**: with the current design, tag updates from the Web UI won't work behind a load balancer/reverse proxy or when only the master exposes the UI. Please either document this limitation or describe how a request reaches the target member. 5. **Docs – `/update-local-member-tags`**: as a new user-facing endpoint it deserves its own section with request, success response and error examples, rather than prose inside the `/update-tags` section. 6. **Robustness – "Restore Latest State"** (`docs/en/engines/zeta/web-ui.md`): please document (or implement and document) the behaviour when the source job is still RUNNING or its checkpoint state has already been cleaned up. 7. **Docs – `/http-service/status`**: add per-field descriptions and use port 8080 in the example to match the rest of the document (currently 5801). 8. **Docs – screenshots** (`web-ui.md`): the new Action controls, Submit Job panel, Checkpoints tab and Operations page are described but still shown with the old screenshots; please update/add images for the new surfaces. If any of these are already addressed in a commit, just point me to it and I'll re-check once the fork workflow is running. <!-- streview-comment:1644 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
