SEZ9 commented on PR #12607: URL: https://github.com/apache/seatunnel/pull/12607#issuecomment-6118293893
Thanks @avnijainnn for the empty-commit retry (`f28268002`) and for describing exactly what you saw: no new fork `Build` run for that SHA, the latest successful `Build` still on `925716e`, and the required check reporting "Workflow run detection failed." To be clear on where things stand: since `f28268002e` is an empty commit on top of `7872659b61`, the code, tests and docs are identical to what I already reviewed, and I still see no source-level blocker. The only open gate is that the `Build` check has no fork run to adopt. The remaining notes from my previous round (per-entry trimming of comma-separated/padded values, the matching test assertion, and the wording of the migration bullet) are non-blocking suggestions; passing nonblank values through untouched is the agreed behaviour for this PR, so feel free to leave those as-is or pick them up in a follow-up. On the CI side, I'll follow up on getting the required workflow retriggered from the repository side. One thing that would help me: could you check your fork's Actions tab and let me know whether any run (queued, skipped or failed) shows up for `f28268002e`, or whether there is nothing at all for that SHA? <!-- streview-comment:1698 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
