DanielLeens commented on PR #11495: URL: https://github.com/apache/seatunnel/pull/11495#issuecomment-6135261008
Quick CI follow-up for head `0ac0f2e5a0`, since my last review said the fork run was still finishing. It has now completed (`zhangshenghang/seatunnel` run 38112486866) and the only failures are `elasticsearch-connector-it (11)` and `(17)`, both in the `elasticsearch_auth_apikey_encoded_temp.conf` Flink container runs. That is outside this PR's three files (pipeline metrics clearing in `SubPlan` / `JobMaster`), and the same Elasticsearch IT failed on an unrelated PR in the same window. The test was stabilised on `dev` after this run by #12711 (polling for index visibility). The `unit-test (11)` and `engine-k8s-it` failures I listed earlier are no longer in the failed set, so please disregard them. This is an inference from the failing job names and logs. So CI is not the blocker here. The code-side items in my last review (Issue 1, the failed attempt's task-group contexts are not cleaned before the metrics clear, so the store can be re-populated) and the similar points from @SEZ9 and @nzw921rx still apply to this head. Once you push a fix, I will re-review the latest head. When you do, please also sync with `dev` and rerun only the failed jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
