DanielLeens commented on code in PR #11495:
URL: https://github.com/apache/seatunnel/pull/11495#discussion_r4291809649
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/SubPlan.java:
##########
@@ -494,6 +494,7 @@ private boolean prepareRestorePipeline() {
String.format(
"Restore time %s, pipeline %s",
pipelineRestoreNum + "", pipelineFullName));
+
jobMaster.clearPipelineMetricsForRestore(getPipelineLocation());
Review Comment:
Thanks @nzw921rx, good question. `reset()` is private and
`prepareRestorePipeline` is its only caller, so the two placements behave the
same today. I would keep the call next to the other restore-path steps where it
is, because `reset()` resets the in-memory SubPlan state and the clear talks to
workers and the master metrics store, but I see it as a style choice and
@zhangshenghang can decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
