SEZ9 commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6183037253
Thanks @ricky2129 for the rundown — that covers all three of my open points. Before I mark them resolved I want to confirm each against the actual diff on the current head `d6f7513761` rather than the summary alone, specifically: 1. **F1 (shutdown policy):** keeping the policy change out of this PR is fine with me, as long as the description/docs state that SIGTERM gives a prompt exit from the cluster (not a graceful stop of running jobs) and that tasks recover from the last checkpoint. Is the `SeaTunnelServer.shutdown` terminate-flag behaviour from the original finding tracked anywhere for a follow-up? 2. **F2 (`terminationGracePeriodSeconds`):** I'll check the master/worker Deployment templates and the `values.yaml` default and `GRACEFUL` note you mention. 3. **F3 (docs):** I'll check the en/zh Kubernetes docs sections and the `preStop` tip. If anything in those areas moved between `45a4730f` and `d6f7513761`, a quick pointer would help; otherwise I'll re-read the diff and close out whatever checks out. Thanks for the thorough follow-through. <!-- streview-comment:1757 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
