DanielLeens commented on PR #11557: URL: https://github.com/apache/seatunnel/pull/11557#issuecomment-6166326612
Thanks @SEZ9. Answers for the two asks, checked against the current head `5dc655e6a91`. **2. Test name confirmation (answering this first because it is a code fact).** `ManagedSourceRegisterOperationSerializationTest` contains exactly two `@Test` methods: `testReaderLocationPayloadRoundTrips` (line 65) and `testMismatchedReaderLocationTypeIsRejected` (line 92). So the "2 tests, 0 failures" count in the earlier JDK 8 job on `b00c3e0cdad` necessarily includes `testMismatchedReaderLocationTypeIsRejected`; there is no third test it could be replaced by. **1. Evidence for the new head.** Delta from `b00c3e0cdad` to `5dc655e6a91` touches only `SourceSplitEnumeratorTask.java`, `ManagedSourceCoordinatorRuntime.java`, `SourceAssignmentTracker.java` and `SourceAssignmentTrackerTest.java` (+59/-10 in total). `ManagedSourceRegisterOperation` and `ManagedSourceRegisterOperationSerializationTest` are untouched, so the F1 behavior you verified is the same code. That is a code-level statement, not executed evidence for the new SHA: the fork Build run 38352742729 is still queued/in progress, so there is no test result for `5dc655e6a91` yet. I will post the executed result of that test class from this run once it finishes and will not ask you to close F1 on the older run alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
