Rangsh commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6246036706
@SEZ9 Status against `ab04db33a`. Nothing pending, and no further commit planned. - F1: intentionally left as-is. Untimed `RequestFuture.get()` is the plain `Future` contract (`latch.await()`, no timeout). No production caller uses it. Documented on the method (`RequestFuture.java` L57–68). - F3/F7: addressed. Timed `get(long, TimeUnit)` throws `TimeoutException` instead of returning false, and `@throws TimeoutException` is on that method (`RequestFuture.java` L70–90). - F2: addressed in `26ce5cb26`. The cache lookup is inside the try, and the catch is `Exception`, so `executeResponse()` cannot kill the single worker (`WALWorkHandler.java` L129–140). - F4: no action from me. Coverage is `WALWorkHandlerSurvivabilityTest` L132–184. - F5: addressed in `26ce5cb26`, so it is not in the `ab04db33a`-only diff. `mockito-junit-jupiter` is test-scoped in `imap-storage-file/pom.xml` (L76–80). `HdfsWriterFlushSyncPathTest` was renamed to `HdfsWriterFlushCallCountTest` in that same commit. - F6: addressed. One shared `deadlineNanos` for the batch, not a fresh full timeout per entry (`IMapFileStorage.java` L352–377). - F8: addressed in `queryExecuteStatus`. One WARN line per timeout (requestId / elapsed / limit), stack at DEBUG. ERROR plus stack is only the unexpected `catch (Exception)` branch (`IMapFileStorage.java` L331–345). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
