SEZ9 commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6281648221
@Rangsh thanks for completing the F8 sentence — that answers it. One WARN line per timeout with `requestId`, elapsed ms and the limit ms, the `TimeoutException` stack only at DEBUG, and ERROR plus a stack reserved for the unexpected `catch (Exception)` branch in `IMapFileStorage.queryExecuteStatus` (L331–345) is exactly the shape I was looking for. A timed-out wait no longer producing a full stack at ERROR resolves F8 on my side. Two small things before I do the final pass: 1. F4: could you confirm how `WALWorkHandler` now behaves after the first write failure (i.e., whether later appends are blocked so no bytes follow a possibly torn record) and which test pins that? I agree reader-side recovery of a partial tail record on restore is out of scope for this PR. 2. Could you confirm that the F8 WARN/DEBUG split and the changes addressing F1–F7 are all in `ab04db33a` (with F2/F5 in `26ce5cb26`), so nothing is still pending locally? If both check out, I have no remaining source-level concerns and will finish the review on that head. <!-- streview-comment:1880 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
