SEZ9 commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6306230094
@Rangsh Thanks for the detailed rundown — appreciate you laying out where each finding stands. 1. **F4:** The fail-close approach you describe (set `appendBlockedAfterWriteFailure` after the first write failure, then have later APPENDs return without touching the writer) is the right direction, and a test asserting the second APPEND completes `false` with the writer invoked only once is what I'd want to see. I'll verify this against the diff on `ab04db33a` rather than take it as settled here. Agreed that reader-side recovery of a partial tail can be a separate follow-up. 2. **F1–F8:** Understood that the F8 WARN/DEBUG split and the F1–F7 changes are on `ab04db33a`, with F2 and F5 having landed in `26ce5cb26`, and that nothing is unpushed. I'll do a read-through of `ab04db33a` against F1–F8 and follow up with anything I find; if the diff matches what you've described, I don't expect further asks on these points. Thanks for the thorough work. <!-- streview-comment:1903 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
