chovy-3012 commented on PR #12703:
URL: https://github.com/apache/seatunnel/pull/12703#issuecomment-6447400857
Thanks @SEPURI-SAI-KRISHNA for catching this, and @DanielLeens for the
recommendation.
Fixed in `e24b7a3f1`: `getFormatter` now uses
`DateTimeFormatter.ofPattern(pattern, Locale.ENGLISH)`, consistent with
`DAYNAME`/`MONTHNAME` (line 355). This covers both the parse path
(`UNIX_TIMESTAMP`) and the format path (`FROM_UNIXTIME`), since both route
through `getFormatter`.
Added two regression tests under `Locale.GERMANY` — `UNIX_TIMESTAMP('23 Oct
2026', 'dd MMM yyyy')` (was NULL without the fix) and `FROM_UNIXTIME(epoch, 'dd
MMM yyyy')` (rendered "Okt" → now "Oct"). Docs updated in both EN and ZH for
`UNIX_TIMESTAMP` and `FROM_UNIXTIME`.
The direct `ofPattern` call in `formatdatetime` (line 640) bypasses
`getFormatter` and is tracked by #12976 — trivial rebase on whichever merges
second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
