SEZ9 commented on PR #12703: URL: https://github.com/apache/seatunnel/pull/12703#issuecomment-6461519482
Thanks for the follow-up in `e24b7a3f1`. Re-checking the head `e24b7a3f1a12` against my last review at `2f0c133e8037`, the delta is the `getFormatter` change (pinning `Locale.ENGLISH`), two new unit tests, and the EN/ZH docs. Everything from my earlier round stays resolved, and the locale fix is in the right place since it is the single choke point for both `UNIX_TIMESTAMP` and `FROM_UNIXTIME`. One remaining item before I approve: because `FROM_UNIXTIME` now goes through the same formatter with a pinned locale, its output for locale-sensitive patterns can change for existing jobs. The `UNIX_TIMESTAMP` shadowing entry is already in `incompatible-changes.md`; could you add a short entry for the `FROM_UNIXTIME` locale change next to it? Once that is in, I'm happy to approve. Thanks for sticking with this. <!-- streview-comment:2101 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
