zhengxiang378928908-code commented on PR #12862: URL: https://github.com/apache/seatunnel/pull/12862#issuecomment-6258810045
Thanks for the review, @DanielLeens. Both points are addressed in 36e16f44f: **Issue 1 (hot path)** - The row converters now pass only the field name down; no string is built per row. A nested `ROW` adds its name to the error (`InvalidWideDecimalException.withParent`) only when a value fails and the exception passes through it, so the message still shows the full path, e.g. `outer.info.inner_big`. - `TypeConverterUtils.convert` no longer walks the type tree for the `ARRAY`/`MAP` check on each call. The real check stays at schema build in `MultiTableManager` (per table, before the merge). As a safety net for other callers, `convert` only carries an "inside a collection" flag through its existing recursion, so there is no second walk. - New test `valueErrorNamesFullPathOfDeeplyNestedColumn` (ROW inside ROW, both converters), and `collectionConversionOutsidePreflightStillFails` now also covers `MAP<STRING, ARRAY<ROW<DECIMAL(39, 0)>>>`. `seatunnel-translation-spark-common` tests: 34 passed locally (JDK 11). **Issue 2**: ticked "Not a connector change" in the description. CI on my fork for the new head is running, and so is the combined run with #12787. I'll post both results here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
