DanielLeens commented on PR #12862: URL: https://github.com/apache/seatunnel/pull/12862#issuecomment-6397064352
Thanks for the clear CI write-up, @zhengxiang378928908-code. I confirmed that the fork `Build` run (https://github.com/zhengxiang378928908-code/seatunnel/actions/runs/40073956878) completed with `success` for head `7b9d94255` (attempt 2). The earlier `mysql-cdc-connector-it (17)` timeout is in a connector this PR does not touch, so re-running only that job was the right call (static reading only, nothing executed locally). My technical conclusion is unchanged from my last review: no open source-side blocker, and I am happy with this head. Since the rebase only resolved the `incompatible-changes.md` conflict, the PR-owned diff matches what was approved earlier. The remaining step is on the committer side: GitHub still shows review required because the earlier committer approval was dismissed by the rebase. @davidzollo, could you please re-approve and re-enqueue when you have a moment? Thanks again for the careful work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
