DanielLeens commented on PR #12862: URL: https://github.com/apache/seatunnel/pull/12862#issuecomment-6289526693
Update on the CI state for head `36e16f44f`, since my last review was written while the run was still in progress. The `Build` check on this head is now completed and green. In the fork run for the same SHA, the job `connector-sensorsdata-it (17)` that I flagged as failing earlier is green, and I see no failed job: License header, Dead links, Dependency licenses, `unit-test` (JDK 11/17 on ubuntu and windows), `all-connectors-it-1..7`, `engine-v2-it`, `engine-k8s-it`, `transform-v2-it` and the JDBC shards all report success. In the `all-connectors-it-6 (11)` job, `FakeSourceToAssertIT` finished with 34 tests run, 0 failures, 0 errors, which includes the two new wide-decimal configs. I did not break the result down per engine, so I cannot separately state the Spark 2.4 / 3.3 numbers. My source-side conclusion is unchanged and I have no remaining code concerns: the previous Medium finding was addressed, the change stays inside `seatunnel-translation-spark-common`, tests and docs, and Issue 1 from my last review was informational only. The branch has no merge conflicts (it is behind `dev`, which is not blocking by itself). Nothing in this comment changes my earlier verdict (Ready to merge); the only item that was open on my side was the CI result, and it is now green. Thanks again for the thorough tests and bilingual docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
