SEZ9 commented on PR #12862: URL: https://github.com/apache/seatunnel/pull/12862#issuecomment-6407810777
Thanks for the clear write-up, @zhengxiang378928908-code, and for keeping the rebase separate from any source changes. Where things stand, based on this thread: - The rebase onto `dev` only resolved the `incompatible-changes.md` (EN/ZH) conflict, keeping both the new `dev` entry and yours. A `range-diff` of head `7b9d94255` against the previously approved head `36e16f44f` shows the PR-owned commits identical apart from the context of that docs hunk, and nothing under `seatunnel-translation` or `connector-assert-e2e` changed on `dev` between the two bases. - Your fork `Build` run 40073956878 for `7b9d94255` is green on attempt 2 (85 passed, 11 skipped). The only first-attempt failure was `MysqlCDCStopModeSpecificIT.testMysqlCdcInitialStartupWithLatestStop` in `mysql-cdc-connector-it (17)` with a `ConditionTimeout`; it passed on JDK 11 in the same run and this PR doesn't touch MySQL-CDC, so re-running just that job was the right call. I have no further code asks. Re-approval and re-enqueueing need a write-capable committer; I can't do either from my side, so that step remains with the committers. Two small asks on your side: 1. Please leave the branch at `7b9d94255` untouched (no force-push, no rebase) until it is through the queue, so the approval and the build result stay bound to the same head. 2. If the required `Build` on the PR hits the same `mysql-cdc-connector-it (17)` flake, just note it here rather than pushing anything, so a committer can re-run the job. Nice work on the wide-decimal handling and on documenting the `ARRAY`/`MAP` rejection behaviour clearly. <!-- streview-comment:2047 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
