SEZ9 commented on issue #12928:
URL: https://github.com/apache/seatunnel/issues/12928#issuecomment-6307426492

   Thanks for the clear reproduction and control matrix. The analysis looks 
plausible: unwrapping the Config to a map and re-parsing it with 
`ConfigFactory.parseMap` loses key quoting, so a literal key like `^t_nova_.*$` 
is reinterpreted as a path. Agreed that both sites you pointed out, 
`resolveDataSourceConfigs()` at `MetadataProviderManager.java:106` and the 
re-parse in `mergeConfig()` at line 346, should be handled in the same 
follow-up.
   
   A possible direction: return the original config unchanged when no connector 
declares `metadata_datasource_id`, and merge resolved datasource configs 
without round-tripping through a raw map. Regression tests in 
`MetadataProviderManagerTest` should cover the quoted-key case with metadata 
enabled and no datasource, plus the disabled and plain-key controls.
   
   On scope: since both of you have offered to work on this, could you agree 
here on who takes it? Whoever picks it up, please keep the change confined to 
metadata resolution and its tests and stay consistent with the conversion 
approach in #12443.
   
   <!-- streview-comment:1919 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to