DanielLeens commented on PR #11495:
URL: https://github.com/apache/seatunnel/pull/11495#issuecomment-6359789807

   Thanks for the dev sync and for rerunning the failed jobs, @zhangshenghang, 
and thanks @SEZ9 for the per-finding recap. I re-checked live: the head is 
still `66f46aa371a7` (the one I last reviewed; the newest commit is a pure 
`dev` merge), so my source conclusion is unchanged and there is no new 
source-side finding from me.
   
   On the CI facts: `Build` is still FAILURE on this head, and I agree the 
failures do not come from this diff, which only touches the pipeline-restore 
metrics cleanup. One small correction to the diagnosis so the next step is the 
right one: the identical failure set on both attempts does not point to a 
random runner problem. The `PreconditionViolationException` / empty 
Testcontainers invocation context provider signature is the known E2E 
infrastructure bug tracked in #12889: with a Zeta-only engine scope, suites 
annotated with `@DisabledOnContainer` get zero containers and JUnit fails every 
test in the class. Its fix, #12895 (`[Fix][E2E] Skip suites when all selected 
containers are disabled`), is still open, which is why a rerun reproduces it 
deterministically. I could only confirm that signature from the logs I had 
access to; I could not re-read the HBase and MySQL-CDC job logs for this head 
(the log endpoint returned errors), so I am not claiming they share the same 
cause.
   
   Minimal next step: please do not add unrelated patches here and no further 
blind reruns are needed. Once #12895 lands in `dev`, sync `dev` once and rerun 
only the failed jobs (`gh run rerun <run-id> --failed`), then drop a note here. 
If any job still fails after that with a different error, post its first error 
and I will check it against the diff.
   
   On SEZ9's F4-F7 recap: they stay non-blocking from my side too; a short note 
in the PR that they are deferred (or a quick pickup if convenient) is enough. 
The remaining gates are a green `Build` on the final head and the final 
maintainer approval. I will recheck as soon as a new commit or a green run is 
posted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to