DanielLeens commented on PR #11495: URL: https://github.com/apache/seatunnel/pull/11495#issuecomment-6338491368
Thanks @SEZ9, @zhangshenghang and @nzw921rx. I checked the disputed restore path on `68f3b7c5`: `SubPlan.prepareRestorePipeline` calls `jobMaster.clearPipelineMetricsForRestore` at 497, before reset. That method calls `cleanTaskGroupContext` at `JobMaster.java:1289` before removing metrics at 1294. The helper sends `CleanTaskGroupContextOperation` to surviving workers at 1321-1325. So the statement that this restore path never sends the operation does not match this head. The remaining in-flight-report race is real and explicitly documented in the method Javadoc (1280-1283): this is best-effort cleanup, not an attempt-fenced metric store or proof that every observable snapshot is zero. I retained that limitation in my previous review rather than claiming exact fencing. EN incompatible-changes.md lines 8-13 already describes the streaming-counter reset and dashboard implications; the ZH entry mirrors it. The shared helper also exists, so its use should be checked before requesting another consolidation. My previous focused test-coverage and cleanup-error-handling suggestions remain non-blocking; I am not closing your review by proxy. There is also a CI correction: the run has completed with failure, superseding my queued note. Besides the four LLM-unit failures, the current run lists engine-v2, HBase, MySQL-CDC, transform-part-2 and all-connectors-part-2/6 failures. They cannot all be described simply as one backpressure error. The inspected logs include the LLM InvalidClassException and empty-template-provider failures in FlinkMetricsIT/TestSparkDateTimeTransformIT. Proposed fixes #12938 and #12895 are still open; the backpressure proposals #12313/#12316 are also open. Syncing current dev alone is not a verified cure. Please keep the existing source discussion separate from those failed stages and rerun affected lanes after their shared corrections are available. My own source conclusion remains unchanged; successful required CI and final maintainer review remain gates. Current status evidence: head `68f3b7c5b75b17ba3c47bd9eac0c49b3f66fd7c2`, base `dev`, compare `diverged` (ahead 9, behind 8), mergeable state `blocked`. CI references: [current Build check](https://github.com/apache/seatunnel/runs/119203277609), [Run / unit-test (11, ubuntu-latest)](https://github.com/zhangshenghang/seatunnel/actions/runs/39575592933/job/119141357504), [Run / all-connectors-it-6 (11, ubuntu-latest)](https://github.com/zhangshenghang/seatunnel/actions/runs/39575592933/job/119141358740). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
