DanielLeens commented on PR #12366: URL: https://github.com/apache/seatunnel/pull/12366#issuecomment-6266733669
Thanks @201811510411lw for syncing with the latest `dev` and resolving the conflicts so quickly. I re-reviewed the new head `b04e9b91f` against my last reviewed head `9b74846d6`. The new head is a merge of `dev`. I diffed all 23 files this PR owns (core `MultiTableSink` / `SupportSinkDataPartition` / `SinkDataPartitioner`, the Paimon sink and `PaimonFixedBucketPartitioner`, the three Flink `SinkExecuteProcessor` copies, `SinkWriteRoutingPartitioner`, tests, `PaimonIT` and its config, and the EN/ZH docs including both `incompatible-changes.md` files) between the two heads, and there is no difference at all. The merge result keeps the compatibility notes intact, and the branch is now 0 commits behind `dev` with no conflicts reported. This is static analysis only; I did not run the PR locally. So my earlier conclusion stands: no source, test or docs blockers. The three agreed follow-ups (avoid the double row conversion on the fixed-bucket path, define behavior for unknown table ids, add a multi-bucket container E2E) remain non-blocking and can go into separate PRs. The only open item is CI: the `Build` run on this head (https://github.com/201811510411lw/seatunnel/actions/runs/39233668483) is still queued, so there is nothing to act on yet. Once it is green, this should be ready for a committer to re-approve and put back into the merge queue. @SEZ9 @davidzollo, the earlier approvals were given on `9b74846d6`, so a fresh approval on this head may be needed for the `dev` ruleset. Thanks again for the patience through all the iterations! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
