fatmanverse commented on PR #12919: URL: https://github.com/apache/seatunnel/pull/12919#issuecomment-6486159789
Thanks @nzw921rx for the review. Both points are addressed in cae8b70 (replies inline), on top of a conflict-free merge of the latest `dev` (886a3ac): - The PostgreSQL-specific handling lives in `PostgresJdbcRowConverter`; `JdbcFieldTypeUtils` and `JdbcFieldTypeUtilsTest` are no longer changed by this PR. - The new catch is narrowed to the `IllegalArgumentException` that pgjdbc 42.4.3 throws for a binary `Infinity` / `-Infinity`, and only that value is read as `null`. `NaN` keeps going through the existing path, since the driver returns it as a `Double`. The PR now changes 4 files: `PostgresJdbcRowConverter`, `PostgresJdbcRowConverterTest`, `JdbcPostgresIT` and the binary-transfer e2e config. On JDK 17, `./mvnw -pl seatunnel-connectors-v2/connector-jdbc test` passes: 1211 tests, 0 failures (6 skipped), `PostgresJdbcRowConverterTest` 19/19 and `JdbcFieldTypeUtilsTest` 16/16. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
