fatmanverse commented on PR #12919: URL: https://github.com/apache/seatunnel/pull/12919#issuecomment-6547138228
I noticed the PR description still described the first version (a catch in the shared `JdbcFieldTypeUtils`), which is no longer what the code does, so I rewrote it for cae8b70: only `PostgresJdbcRowConverter` changes, it catches only `IllegalArgumentException`, and only an 8-byte header with no digit words and the sign `0xD000` / `0xF000` is read as null. The code is unchanged. I also added a note on driver versions. The `IllegalArgumentException` comes from pgjdbc before 42.7.4, including the bundled 42.4.3. Since 42.7.4 (pgjdbc #3304) the driver decodes the infinities and `getBigDecimal` throws `PSQLException: Bad value for type BigDecimal` instead, which the existing `SQLException` path already reads as null. So the new branch only runs with older drivers, and newer ones behave correctly without it. Re-checked on JDK 17 against the latest `dev` (f3e1c2ee3), merged together with the other open JDBC PRs: `connector-jdbc` unit tests 1259 run, 0 failures; `JdbcPostgresIT#testNumericSpecialValue*` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
