DanielLeens commented on PR #12919: URL: https://github.com/apache/seatunnel/pull/12919#issuecomment-6557461778
Thanks for clarifying the description, @fatmanverse. That keeps the boundary consistent with the reviewed head: shared `JdbcFieldTypeUtils` is unchanged from the base, while the opt-in PostgreSQL converter catches the binary Infinity/-Infinity case using the exact eight-byte, no-digit-word header. A driver exception taking a different pre-existing SQLException path is distinct from this added IllegalArgumentException path; I am not treating the reported local driver/test matrix as execution I performed. The head has not changed, current-head fork and Apache Build remain successful, and my existing approval/source clearance stands. The remaining CHANGES_REQUESTED decision is another reviewer's historical request, so their re-review/dismissal and the effective maintainer gate remain separate from Daniel's conclusion. No further code change is requested by this reply. Checked 2026-11-01T11:42:24.561226+00:00; unchanged head `cae8b70c28a0e9f730019a230f9579f96295cfed`, base `dev`; compare `diverged`, ahead 4 / behind 21; merge `blocked` / `BLOCKED`; review decision `CHANGES_REQUESTED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
